style: Use iter for IntoIterator parameter names
#32438
Merged
+43
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
I would have assumed |
|
Good point. Furthre investigation: Should I standardize all uses on |
|
Let's do it 👍 Thanks for double checking. |
This commit standardizes the codebase on `iter` for parameters with IntoIterator bounds. Previously about 40% of IntoIterator parameters were named `iterable`, with most of the rest being named `iter`. There was a single place where it was named `iterator`.
kamalmarhubi
changed the title
iter for IntoIterator parameter names
kamalmarhubi
force-pushed
the
intoiterator-example
branch
from
fd46ae7 to
93569ac
Compare
|
@steveklabnik ping! (was a way for a few days) |
|
@bors: r+ rollup No worries, I was too :) |
|
📌 Commit 93569ac has been approved by |
bors
added a commit
that referenced
this pull request
Mar 29, 2016
style: Use `iter` for IntoIterator parameter names This commit standardizes the codebase on `iter` for parameters with IntoIterator bounds. Previously about 40% of IntoIterator parameters were named `iterable`, with most of the rest being named `iter`. There was a single place where it was named `iterator`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit standardizes the codebase on
iterfor parameters withIntoIterator bounds.
Previously about 40% of IntoIterator parameters were named
iterable,with most of the rest being named
iter. There was a single place whereit was named
iterator.