libstd/sys/*/net: clean up API error checks. #32510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -167,7 +167,7 @@ impl TcpStream { | |||
| let sock = Socket::new(addr, c::SOCK_STREAM)?; | |||
|
|
|||
| let (addrp, len) = addr.into_inner(); | |||
| cvt_r(|| unsafe { c::connect(*sock.as_inner(), addrp, len) })?; | |||
| cvt(unsafe { c::connect(*sock.as_inner(), addrp, len) })?; | |||
There was a problem hiding this comment.
Why are these switching away from cvt_r? They're supposed to handle EINTR internally and this change means that they no longer handle that.
Signed-off-by: NODA, Kai <[email protected]>
nodakai
force-pushed
the
libstd-sys-net-error-check
branch
from
0b277b0 to
bf94aef
Compare
|
@alexcrichton Apologies, I must have been absent... I was reviving a very old patch of mine and screwed it up in the end |
bors
added a commit
that referenced
this pull request
Mar 27, 2016
…hton libstd/sys/*/net: clean up API error checks. 1. Slightly improve `cvt_gai()` and `cvt()`. 2. Remove now redundant `cvt_r()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cvt_gai()andcvt().cvt_r().