Mode removal ++ #3362
Closed
Mode removal ++ #3362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Many thanks for all your hard work doing this stuff. |
|
Pushed to incoming. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits confirm demoding of term.rs, smallintmap.rs, and demode treemap.rs, net_url.rs, and net_ip.rs. Of these things, take a closer look at the net stuff, because I haven't really played with libuv enough yet to feel like I'm anticipating the possible issues.
Tested on incoming (7fb1a4e) with
CFG_DISABLE_VALGRIND=1 make check. :)