Skip to content

run rustfmt on libcollections test module #33795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2016
Merged

run rustfmt on libcollections test module #33795

merged 2 commits into from
May 27, 2016

Conversation

srinivasreddy
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@srinivasreddy
Copy link
Contributor Author

r? @Manishearth

@rust-highfive rust-highfive assigned Manishearth and unassigned aturon May 22, 2016
@srinivasreddy
Copy link
Contributor Author

cc @nrc

///////////////////////////////////////////////////////////////////////////
// intersect

/// ////////////////////////////////////////////////////////////////////////
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you manually fixup these comment changes please (to undo what rustfmt has done)

@nrc
Copy link
Member

nrc commented May 23, 2016

r+ with the inline comments addressed

@srinivasreddy
Copy link
Contributor Author

@nrc done. Thanks

@nrc
Copy link
Member

nrc commented May 23, 2016

Thanks!

@bors: r+

@bors
Copy link
Collaborator

bors commented May 23, 2016

📌 Commit f6edd51 has been approved by nrc

@@ -220,6 +222,7 @@ fn test_overflow() {
#[allow(dead_code)]
#[derive(Copy, Clone)]
#[repr(usize)]
#[rustfmt_skip]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this caused the build problem.
The error can be seen here.

@bors
Copy link
Collaborator

bors commented May 23, 2016

⌛ Testing commit f6edd51 with merge dc4f6e0...

@bors
Copy link
Collaborator

bors commented May 23, 2016

💔 Test failed - auto-mac-64-opt

@srinivasreddy
Copy link
Contributor Author

@nrc removed #[rustfmt_skip] . Please approve. Thanks

@nrc
Copy link
Member

nrc commented May 26, 2016

@bors: r+

@bors
Copy link
Collaborator

bors commented May 26, 2016

📌 Commit 69db6e6 has been approved by nrc

@bors
Copy link
Collaborator

bors commented May 27, 2016

⌛ Testing commit 69db6e6 with merge 8fa02a5...

@bors
Copy link
Collaborator

bors commented May 27, 2016

⛄ The build was interrupted to prioritize another pull request.

@bors
Copy link
Collaborator

bors commented May 27, 2016

⌛ Testing commit 69db6e6 with merge 17b6261...

bors added a commit that referenced this pull request May 27, 2016
run rustfmt on libcollections test module
@bors bors merged commit 69db6e6 into rust-lang:master May 27, 2016
@srinivasreddy srinivasreddy deleted the lib_coll_test branch May 27, 2016 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants