-
Notifications
You must be signed in to change notification settings - Fork 13.5k
doc: Correct char::escape_unicode documentation. #33987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jroesch (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Is this true? The example below only shows four. The backslash fix is good for sure, though! |
@steveklabnik of course, the unicode scalar value range is up to 10FFFF. I've also given it a test on my machine for sure though. |
What's the status of this? |
This got lost because I wasn't assigned, gah! And I've kicked off Travis again. |
📌 Commit 5583d81 has been approved by |
fails travis |
@Manishearth it does, but it seems extremely spurious. And this change shouldn't affect any tests or code at all, it's solely in a comment. |
Ah, okay. I didn't look at the failure, just noted it when making the rollup and excluded it. |
doc: Correct char::escape_unicode documentation. A quick fix for documentation.
A quick fix for documentation.