Skip to content

doc: Correct char::escape_unicode documentation. #33987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2016

Conversation

crlf0710
Copy link
Member

A quick fix for documentation.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jroesch (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

Is this true? The example below only shows four. The backslash fix is good for sure, though!

@crlf0710
Copy link
Member Author

crlf0710 commented Jun 1, 2016

@steveklabnik of course, the unicode scalar value range is up to 10FFFF. I've also given it a test on my machine for sure though.

@apasel422
Copy link
Contributor

What's the status of this?

@steveklabnik steveklabnik self-assigned this Jul 7, 2016
@steveklabnik
Copy link
Member

This got lost because I wasn't assigned, gah! And I've kicked off Travis again.

@steveklabnik
Copy link
Member

Well, travis is being weird still, but since this is text, it shouldn't affect much.

@crlf0710 sorry about the delay here!

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 7, 2016

📌 Commit 5583d81 has been approved by steveklabnik

@Manishearth
Copy link
Member

fails travis

@steveklabnik
Copy link
Member

@Manishearth it does, but it seems extremely spurious. And this change shouldn't affect any tests or code at all, it's solely in a comment.

@Manishearth
Copy link
Member

Ah, okay.

I didn't look at the failure, just noted it when making the rollup and excluded it.

@bors
Copy link
Collaborator

bors commented Jul 9, 2016

⌛ Testing commit 5583d81 with merge a4327d9...

bors added a commit that referenced this pull request Jul 9, 2016
doc: Correct char::escape_unicode documentation.

A quick fix for documentation.
@bors bors merged commit 5583d81 into rust-lang:master Jul 9, 2016
@crlf0710 crlf0710 deleted the patch-1 branch July 10, 2016 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants