Err codes

[GuillaumeGomez]

r? @jonathandturner

[sophiajt]

@bors r+

[bors]

📌 Commit 6f05f21 has been approved by jonathandturner

[bors]

⌛ Testing commit 6f05f21 with merge 893c7c6...

[bors]

💔 Test failed - auto-win-gnu-32-opt-rustbuild

[GuillaumeGomez]

Updated.

[sophiajt]

@bors r+

[bors]

📌 Commit 24a8a75 has been approved by jonathandturner

[bors]

⌛ Testing commit 24a8a75 with merge 4b8ffe5...

[bors]

💔 Test failed - auto-win-gnu-32-opt-rustbuild

[sophiajt]

Failure looks legit:

---- Rust_Compiler_Error_Index_329 stdout ----
    <anon>:3:1: 8:2 warning: enum is never used: `Foo`, #[warn(dead_code)] on by default 
<anon>:3 enum Foo {
         ^
<anon>:4:9: 4:27 error: literal out of range for isize 
<anon>:4     X = 0x7fffffffffffffff,
                 ^~~~~~~~~~~~~~~~~~
<anon>:2:12: 2:32 note: lint level defined here 
<anon>:2     #[deny(overflowing_literals)]
                    ^~~~~~~~~~~~~~~~~~~~
thread 'Rust_Compiler_Error_Index_329' panicked at 'Some expected error codes were not found: ["E0370"]', C:\bot\slave\auto-win-gnu-32-opt-rustbuild\build\src\librustdoc\test.rs:297


failures:
    Rust_Compiler_Error_Index_329

[GuillaumeGomez]

Not really since it works locally. I really don't understand the difference between the two...

[GuillaumeGomez]

I removed the change for the problem. I'll go back on it later.

[sophiajt]

@GuillaumeGomez - is it ready for r+?

[GuillaumeGomez]

Yes.

[sophiajt]

@bors r+

[bors]

📌 Commit f9ca8d8 has been approved by jonathandturner

[bors]

⌛ Testing commit f9ca8d8 with merge fa4b278...

[TimNN]

@GuillaumeGomez I believe the default enum discriminant type is isize thus on 64bit platforms you get the expected error but on 32bit platforms the deny(overflowing_literals) lint triggers first, so a potential fix would probably be to mark the enum as #[repr(i64)].

[GuillaumeGomez]

@TimNN: Great idea! Want to do it? :)

[bors]

💔 Test failed - auto-win-gnu-32-opt-rustbuild

[GuillaumeGomez]

Updated.

[TimNN]

@GuillaumeGomez: I'm pretty sure that compile-fail/E0370.rs will now fail on 64 bit platforms.

[GuillaumeGomez]

Ah right. I need to add the repr.

[GuillaumeGomez]

NOW it should be done.

[TimNN]

@GuillaumeGomez shouldn't it be

#[repr(i64)]
enum Foo {
    X = 0x7fffffffffffffff,
    Y, //~ ERROR E0370
}

fn main() {}

?

[GuillaumeGomez]

Yes it should... Why did I change it?

[GuillaumeGomez]

And updated.

[sophiajt]

@bors r+

[bors]

📌 Commit 0658941 has been approved by jonathandturner

[bors]

⌛ Testing commit 0658941 with merge 296f8f9...

[bors]

💔 Test failed - auto-linux-64-debug-opt

[GuillaumeGomez]

@bors: retry

[sophiajt]

@bors p=1

[bors]

⌛ Testing commit 0658941 with merge 1deb02e...

[bors]

💔 Test failed - auto-linux-64-debug-opt

[sophiajt]

@bors retry

[bors]

⚡ Previous build results for auto-linux-32-nopt-t, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-opt, auto-linux-64-opt-no-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt-rustbuild are reusable. Rebuilding only auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-mac-32-opt, auto-win-gnu-32-opt, auto-win-msvc-64-opt, auto-win-msvc-64-opt-no-mir...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-no-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-no-mir, auto-win-msvc-64-opt-rustbuild
Approved by: jonathandturner
Pushing 1deb02e to master...