Skip to content

Use less size_t casts in libstd since it's now defined as usize #37041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libstd/primitive_docs.rs
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ mod prim_unit { }
///
/// fn main() {
/// unsafe {
/// let my_num: *mut i32 = libc::malloc(mem::size_of::<i32>() as libc::size_t) as *mut i32;
/// let my_num: *mut i32 = libc::malloc(mem::size_of::<i32>()) as *mut i32;
/// if my_num.is_null() {
/// panic!("failed to allocate memory");
/// }
Expand Down
6 changes: 3 additions & 3 deletions src/libstd/sys/unix/fd.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#![unstable(reason = "not public", issue = "0", feature = "fd")]

use io::{self, Read};
use libc::{self, c_int, size_t, c_void};
use libc::{self, c_int, c_void};
use mem;
use sync::atomic::{AtomicBool, Ordering};
use sys::cvt;
Expand Down Expand Up @@ -40,7 +40,7 @@ impl FileDesc {
let ret = cvt(unsafe {
libc::read(self.fd,
buf.as_mut_ptr() as *mut c_void,
buf.len() as size_t)
buf.len())
})?;
Ok(ret as usize)
}
Expand All @@ -54,7 +54,7 @@ impl FileDesc {
let ret = cvt(unsafe {
libc::write(self.fd,
buf.as_ptr() as *const c_void,
buf.len() as size_t)
buf.len())
})?;
Ok(ret as usize)
}
Expand Down
2 changes: 1 addition & 1 deletion src/libstd/sys/unix/fs.rs
Original file line number Diff line number Diff line change
Expand Up @@ -669,7 +669,7 @@ pub fn readlink(p: &Path) -> io::Result<PathBuf> {

loop {
let buf_read = cvt(unsafe {
libc::readlink(p, buf.as_mut_ptr() as *mut _, buf.capacity() as libc::size_t)
libc::readlink(p, buf.as_mut_ptr() as *mut _, buf.capacity())
})? as usize;

unsafe { buf.set_len(buf_read); }
Expand Down
4 changes: 2 additions & 2 deletions src/libstd/sys/unix/memchr.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ pub fn memchr(needle: u8, haystack: &[u8]) -> Option<usize> {
libc::memchr(
haystack.as_ptr() as *const libc::c_void,
needle as libc::c_int,
haystack.len() as libc::size_t)
haystack.len())
};
if p.is_null() {
None
Expand All @@ -39,7 +39,7 @@ pub fn memrchr(needle: u8, haystack: &[u8]) -> Option<usize> {
libc::memrchr(
haystack.as_ptr() as *const libc::c_void,
needle as libc::c_int,
haystack.len() as libc::size_t)
haystack.len())
};
if p.is_null() {
None
Expand Down
2 changes: 1 addition & 1 deletion src/libstd/sys/unix/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ pub fn init() {
unsafe {
libc::write(libc::STDERR_FILENO,
msg.as_ptr() as *const libc::c_void,
msg.len() as libc::size_t);
msg.len());
intrinsics::abort();
}
}
Expand Down
19 changes: 9 additions & 10 deletions src/libstd/sys/unix/os.rs
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ pub fn error_string(errno: i32) -> String {

let p = buf.as_mut_ptr();
unsafe {
if strerror_r(errno as c_int, p, buf.len() as libc::size_t) < 0 {
if strerror_r(errno as c_int, p, buf.len()) < 0 {
panic!("strerror_r failure");
}

Expand All @@ -108,7 +108,7 @@ pub fn getcwd() -> io::Result<PathBuf> {
loop {
unsafe {
let ptr = buf.as_mut_ptr() as *mut libc::c_char;
if !libc::getcwd(ptr, buf.capacity() as libc::size_t).is_null() {
if !libc::getcwd(ptr, buf.capacity()).is_null() {
let len = CStr::from_ptr(buf.as_ptr() as *const libc::c_char).to_bytes().len();
buf.set_len(len);
buf.shrink_to_fit();
Expand Down Expand Up @@ -200,21 +200,20 @@ pub fn current_exe() -> io::Result<PathBuf> {
libc::KERN_PROC as c_int,
libc::KERN_PROC_PATHNAME as c_int,
-1 as c_int];
let mut sz: libc::size_t = 0;
let mut sz = 0;
cvt(libc::sysctl(mib.as_mut_ptr(), mib.len() as ::libc::c_uint,
ptr::null_mut(), &mut sz, ptr::null_mut(),
0 as libc::size_t))?;
ptr::null_mut(), &mut sz, ptr::null_mut(), 0))?;
if sz == 0 {
return Err(io::Error::last_os_error())
}
let mut v: Vec<u8> = Vec::with_capacity(sz as usize);
let mut v: Vec<u8> = Vec::with_capacity(sz);
cvt(libc::sysctl(mib.as_mut_ptr(), mib.len() as ::libc::c_uint,
v.as_mut_ptr() as *mut libc::c_void, &mut sz,
ptr::null_mut(), 0 as libc::size_t))?;
ptr::null_mut(), 0))?;
if sz == 0 {
return Err(io::Error::last_os_error());
}
v.set_len(sz as usize - 1); // chop off trailing NUL
v.set_len(sz - 1); // chop off trailing NUL
Ok(PathBuf::from(OsString::from_vec(v)))
}
}
Expand Down Expand Up @@ -488,7 +487,7 @@ pub fn home_dir() -> Option<PathBuf> {
buf: &mut Vec<c_char>) -> Option<()> {
let mut result = ptr::null_mut();
match libc::getpwuid_r(me, passwd, buf.as_mut_ptr(),
buf.capacity() as libc::size_t,
buf.capacity(),
&mut result) {
0 if !result.is_null() => Some(()),
_ => None
Expand All @@ -501,7 +500,7 @@ pub fn home_dir() -> Option<PathBuf> {
// getpwuid_r semantics is different on Illumos/Solaris:
// http://illumos.org/man/3c/getpwuid_r
let result = libc::getpwuid_r(me, passwd, buf.as_mut_ptr(),
buf.capacity() as libc::size_t);
buf.capacity());
if result.is_null() { None } else { Some(()) }
}

Expand Down
6 changes: 3 additions & 3 deletions src/libstd/sys/unix/rand.rs
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@ mod imp {
// full entropy pool
let reader = File::open("/dev/urandom").expect("Unable to open /dev/urandom");
let mut reader_rng = ReaderRng::new(reader);
reader_rng.fill_bytes(& mut v[read..]);
read += v.len() as usize;
reader_rng.fill_bytes(&mut v[read..]);
read += v.len();
} else {
panic!("unexpected getrandom error: {}", err);
}
Expand Down Expand Up @@ -281,7 +281,7 @@ mod imp {
}
fn fill_bytes(&mut self, v: &mut [u8]) {
let ret = unsafe {
SecRandomCopyBytes(kSecRandomDefault, v.len() as size_t,
SecRandomCopyBytes(kSecRandomDefault, v.len(),
v.as_mut_ptr())
};
if ret == -1 {
Expand Down
29 changes: 12 additions & 17 deletions src/libstd/sys/unix/thread.rs
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ impl Thread {

let stack_size = cmp::max(stack, min_stack_size(&attr));
match pthread_attr_setstacksize(&mut attr,
stack_size as libc::size_t) {
stack_size) {
0 => {}
n => {
assert_eq!(n, libc::EINVAL);
Expand All @@ -64,7 +64,6 @@ impl Thread {
let page_size = os::page_size();
let stack_size = (stack_size + page_size - 1) &
(-(page_size as isize - 1) as usize - 1);
let stack_size = stack_size as libc::size_t;
assert_eq!(libc::pthread_attr_setstacksize(&mut attr,
stack_size), 0);
}
Expand Down Expand Up @@ -264,12 +263,8 @@ pub mod guard {
// Rellocate the last page of the stack.
// This ensures SIGBUS will be raised on
// stack overflow.
let result = mmap(stackaddr,
psize as libc::size_t,
PROT_NONE,
MAP_PRIVATE | MAP_ANON | MAP_FIXED,
-1,
0);
let result = mmap(stackaddr, psize, PROT_NONE,
MAP_PRIVATE | MAP_ANON | MAP_FIXED, -1, 0);

if result != stackaddr || result == MAP_FAILED {
panic!("failed to allocate a guard page");
Expand All @@ -293,8 +288,8 @@ pub mod guard {

#[cfg(target_os = "macos")]
pub unsafe fn current() -> Option<usize> {
Some((libc::pthread_get_stackaddr_np(libc::pthread_self()) as libc::size_t -
libc::pthread_get_stacksize_np(libc::pthread_self())) as usize)
Some((libc::pthread_get_stackaddr_np(libc::pthread_self()) as usize -
libc::pthread_get_stacksize_np(libc::pthread_self())))
}

#[cfg(any(target_os = "openbsd", target_os = "bitrig"))]
Expand All @@ -306,10 +301,10 @@ pub mod guard {
let extra = if cfg!(target_os = "bitrig") {3} else {1} * os::page_size();
Some(if libc::pthread_main_np() == 1 {
// main thread
current_stack.ss_sp as usize - current_stack.ss_size as usize + extra
current_stack.ss_sp as usize - current_stack.ss_size + extra
} else {
// new thread
current_stack.ss_sp as usize - current_stack.ss_size as usize
current_stack.ss_sp as usize - current_stack.ss_size
})
}

Expand All @@ -335,11 +330,11 @@ pub mod guard {
&mut size), 0);

ret = if cfg!(target_os = "freebsd") {
Some(stackaddr as usize - guardsize as usize)
Some(stackaddr as usize - guardsize)
} else if cfg!(target_os = "netbsd") {
Some(stackaddr as usize)
} else {
Some(stackaddr as usize + guardsize as usize)
Some(stackaddr as usize + guardsize)
};
}
assert_eq!(libc::pthread_attr_destroy(&mut attr), 0);
Expand All @@ -358,8 +353,8 @@ fn min_stack_size(attr: *const libc::pthread_attr_t) -> usize {
weak!(fn __pthread_get_minstack(*const libc::pthread_attr_t) -> libc::size_t);

match __pthread_get_minstack.get() {
None => libc::PTHREAD_STACK_MIN as usize,
Some(f) => unsafe { f(attr) as usize },
None => libc::PTHREAD_STACK_MIN,
Some(f) => unsafe { f(attr) },
}
}

Expand All @@ -368,7 +363,7 @@ fn min_stack_size(attr: *const libc::pthread_attr_t) -> usize {
#[cfg(all(not(target_os = "linux"),
not(target_os = "netbsd")))]
fn min_stack_size(_: *const libc::pthread_attr_t) -> usize {
libc::PTHREAD_STACK_MIN as usize
libc::PTHREAD_STACK_MIN
}

#[cfg(target_os = "netbsd")]
Expand Down