Prevent Windows from displaying UI on errors. #38231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
Looks good to me, thanks! Could this be added to a different location though? It seems like we should always do this but there's a few early-return locations in the method where it was added. |
|
Ok, I moved it to the top. |
|
@bors: r+ |
|
📌 Commit cc16122 has been approved by |
|
Per https://blogs.msdn.microsoft.com/oldnewthing/20040727-00/?p=38323, it's best to preserve inherited flags. |
|
📌 Commit 6404143 has been approved by |
|
⌛ Testing commit 6404143 with merge 26c3797... |
|
@bors: retry force clean |
|
⌛ Testing commit 6404143 with merge 8bbe326... |
|
💔 Test failed - auto-win-msvc-64-cargotest |
|
@bors: retry
…On Sat, Dec 10, 2016 at 4:55 AM, bors ***@***.***> wrote:
💔 Test failed - auto-win-msvc-64-cargotest
<https://buildbot.rust-lang.org/builders/auto-win-msvc-64-cargotest/builds/2552>
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#38231 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95KTAteVb4i_nH5reR7Ks4COgIbCBks5rGqE1gaJpZM4LHRr1>
.
|
bors
added a commit
that referenced
this pull request
Dec 10, 2016
Prevent Windows from displaying UI on errors. Otherwise tests like run-pass/out-of-stack get wedged on Windows error reporting dialog (unless error reporting has been disabled, of course).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise tests like run-pass/out-of-stack get wedged on Windows error reporting dialog (unless error reporting has been disabled, of course).