Skip to content

Minor improvement to strange grammar in E0525 #39072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2017
Merged

Minor improvement to strange grammar in E0525 #39072

merged 2 commits into from
Jan 16, 2017

Conversation

radix
Copy link
Contributor

@radix radix commented Jan 15, 2017

Hi, I just ran into this error from rustc, and it had some strange grammar, so I cleaned it up a bit.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@@ -1618,8 +1618,7 @@ fn cookie() -> ! { // error: definition of an unknown language item: `cookie`
"##,

E0525: r##"
A closure was attempted to get used whereas it doesn't implement the expected
trait.
A closure was used where it didn't implement the expected trait.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow this is much better. Maybe it can improve a little further like this? "[...] was used but didn't implement [...]"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that is much better, I'll fix it :)

@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+

@bors
Copy link
Collaborator

bors commented Jan 15, 2017

📌 Commit ac321a7 has been approved by GuillaumeGomez

@bors
Copy link
Collaborator

bors commented Jan 16, 2017

⌛ Testing commit ac321a7 with merge 11ad6fe...

bors added a commit that referenced this pull request Jan 16, 2017
Minor improvement to strange grammar in E0525

Hi, I just ran into this error from rustc, and it had some strange grammar, so I cleaned it up a bit.
@bors
Copy link
Collaborator

bors commented Jan 16, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: GuillaumeGomez
Pushing 11ad6fe to master...

@bors bors merged commit ac321a7 into rust-lang:master Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants