-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Minor improvement to strange grammar in E0525 #39072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@@ -1618,8 +1618,7 @@ fn cookie() -> ! { // error: definition of an unknown language item: `cookie` | |||
"##, | |||
|
|||
E0525: r##" | |||
A closure was attempted to get used whereas it doesn't implement the expected | |||
trait. | |||
A closure was used where it didn't implement the expected trait. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wow this is much better. Maybe it can improve a little further like this? "[...] was used but didn't implement [...]"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that is much better, I'll fix it :)
Thanks! @bors: r+ |
📌 Commit ac321a7 has been approved by |
Minor improvement to strange grammar in E0525 Hi, I just ran into this error from rustc, and it had some strange grammar, so I cleaned it up a bit.
☀️ Test successful - status-appveyor, status-travis |
Hi, I just ran into this error from rustc, and it had some strange grammar, so I cleaned it up a bit.