Create directory for dump-mir-dir automatically #42402
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Let's leave the suggestion to set a default for later; I don't think there's any good option -- The changes here look good, though it looks like there are some Travis errors, but otherwise r=me once those are fixed. |
citizen428
force-pushed
the
create-dump-mir-dir
branch
from
01ed626 to
2a37364
Compare
|
Let's actually just ignore the error when creating it |
Mark-Simulacrum
added
the
S-waiting-on-author
citizen428
force-pushed
the
create-dump-mir-dir
branch
from
2a37364 to
82caf21
Compare
|
@Mark-Simulacrum It's done. |
|
@bors r+ rollup |
|
📌 Commit 82caf21 has been approved by |
Mark-Simulacrum
added
S-waiting-on-bors
Create directory for dump-mir-dir automatically Fixes #35543 r? @Mark-Simulacrum @Mark-Simulacrum I know someone else said that they'll work on this, but it has been 3+ weeks and I had nothing to do and wanted to contribute a bit. I now added the call to automatically create the directory as discussed, but was wondering how you feel about the suggestion to set a default directory, i.e. `target/mir`?
|
☀️ Test successful - status-appveyor, status-travis |
|
Sorry for that, I haven't spend any time on that issue within 3+ weeks, nice job @citizen428 😃 |
|
No problem @wdv4758h 😃 I had a short amount of time and was looking for an easy issue to clean out, this was it. |
Fixes #35543 r? @Mark-Simulacrum
@Mark-Simulacrum I know someone else said that they'll work on this, but it has been 3+ weeks and I had nothing to do and wanted to contribute a bit.
I now added the call to automatically create the directory as discussed, but was wondering how you feel about the suggestion to set a default directory, i.e.
target/mir?