Skip to content

Upload linux-x86_64 artifacts on try branch. #42418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 4, 2017
Merged

Upload linux-x86_64 artifacts on try branch. #42418

merged 2 commits into from
Jun 4, 2017

Conversation

tomprince
Copy link
Member

This is an experiment to explore generating artifacts for testing with cargobmomb. See rust-lang/crater#64.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Mark-Simulacrum
Mark-Simulacrum requested changes Jun 4, 2017
View reviewed changes
.travis.yml Outdated
if [ "$ALLOW_PR" = "" ] && [ "$TRAVIS_BRANCH" != "auto" ]; then
export RUN_SCRIPT="echo 'skipping, not a full build'";
else
if [[ "$ALLOW_PR" = "1" || "$TRAVIS_BRANCH" == "auto" || ( "$ALLOW_TRY" = "1" && "$TRAVIS_BRANCH" = "try" ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ( appears to be unclosed.

@Mark-Simulacrum
Copy link
Member

@bors try

@bors
Copy link
Collaborator

bors commented Jun 4, 2017

⌛ Trying commit abb50f2 with merge 69feff5...

@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jun 4, 2017
Closed
Mark-Simulacrum
Mark-Simulacrum requested changes Jun 4, 2017
View reviewed changes
.travis.yml Outdated
SKIP_BUILD=true
fi
# Otherwise, do the build if we are on the auto branch, or the try branch and $ALLOW_TRY == 1
elif [[ "$TRAVIS_BRANCH" == "auto" || ( "$ALLOW_TRY" == "1" || "$TRAVIS_BRANCH" == "try" ) ]]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allow try && try branch

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, no, this is correct. Never mind.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your first comment was correct.

@tomprince
Copy link
Member Author

Can somebody trigger another try run of this before landing, to check that the build starts? Once the IMAGE=dist-x86_64-linux DEPLOY=1 ALLOW_TRY=1 has started running, it can be canceled.

@tomprince
Copy link
Member Author

The artifacts got successfully uploaded to s3://rust-lang-ci/rustc-builds-try/69feff5004e7a1844708151ebd9a57d576dadfc7/ from the try build.

@tomprince tomprince force-pushed the try-deploy branch 3 times, most recently from 417c3b1 to 7994e1a Compare June 4, 2017 05:14
@Mark-Simulacrum @tomprince
Don't run travis tests on master.
d2ff798 
This saves us builders for more helpful purposes.
@Mark-Simulacrum
Copy link
Member

@bors try

@bors
Copy link
Collaborator

bors commented Jun 4, 2017

⌛ Trying commit d2ff798 with merge d33ebd0...

bors added a commit that referenced this pull request Jun 4, 2017
@bors
Auto merge of #42418 - tomprince:try-deploy, r=<try>
d33ebd0 
Upload linux-x86_64 artifacts on try branch.

This is an experiment to explore generating artifacts for testing with cargobmomb. See rust-lang/crater#64.
@Mark-Simulacrum
Copy link
Member

I don't know of homu is supposed to print something, but try succeeded. I guess that makes this successful -- r? @alexcrichton for final sign off though.

@tomprince
Copy link
Member Author

Here are the builds:

  • PR (which only has IMAGE=x86_64-gnu-llvm-3.7 ALLOW_PR=1 RUST_BACKTRACE=1 running)
  • try (which only has IMAGE=dist-x86_64-linux DEPLOY=1 ALLOW_TRY=1 running and has artifacts at s3://rust-lang-ci/rustc-builds-try/d33ebd0b1c28aeb1823df5314c578586feaa6bd6/

As this merges,

  • The auto build should build everything.
  • The masterbuild should build nothing.

@Mark-Simulacrum
Copy link
Member

Actually, I believe @alexcrichton gave approval over IRC yesterday.

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 4, 2017

📌 Commit d2ff798 has been approved by Mark-Simulacrum

@Mark-Simulacrum
Copy link
Member

@bors retry

@bors
Copy link
Collaborator

bors commented Jun 4, 2017

⌛ Testing commit d2ff798 with merge 341f453...

bors added a commit that referenced this pull request Jun 4, 2017
@bors
Auto merge of #42418 - tomprince:try-deploy, r=Mark-Simulacrum
341f453 
Upload linux-x86_64 artifacts on try branch.

This is an experiment to explore generating artifacts for testing with cargobmomb. See rust-lang/crater#64.
@bors
Copy link
Collaborator

bors commented Jun 4, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing 341f453 to master...

@bors bors merged commit d2ff798 into rust-lang:master Jun 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum approved these changes

Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tomprince @rust-highfive @Mark-Simulacrum @bors @alexcrichton @nikomatsakis