Update RLS and deps #43611
Merged
Update RLS and deps #43611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
kennytm
reviewed
Aug 2, 2017
| .unwrap_or(i.to_string())) | ||
| .filter_map(|(i, f)| { | ||
| if include_priv_fields || f.vis == ast::Visibility::Public { | ||
| f.ident.map(|i| i.to_string()).or_else(|| Some(i.to_string())) |
|
r? @eddyb |
|
@bors r+ |
|
📌 Commit f055333 has been approved by |
|
⌛ Testing commit f055333ee25046f8f2e6c3e1958580cacef85fb2 with merge cd2a1e9fa2cc38472d8bca5b8b0207831d185a0b... |
|
💔 Test failed - status-travis |
|
@bors: r=eddyb |
|
📌 Commit 2683ba6 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 3, 2017
Update RLS and deps This PR further moves towards configuring save-analysis using the rls-data Config struct. We remove completely the concept of api_crate. Updates the RLS so the client is expecting these changes and which pulls in a commit re-enabling all RLS tests (been disabled due to a span error for a while).
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Aug 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR further moves towards configuring save-analysis using the rls-data Config struct. We remove completely the concept of api_crate. Updates the RLS so the client is expecting these changes and which pulls in a commit re-enabling all RLS tests (been disabled due to a span error for a while).