Skip to content

Fix a number of failing tests on Solaris and SPARC #43634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 4, 2017

Conversation

dhduvall
Copy link

@dhduvall dhduvall commented Aug 4, 2017

No description provided.

Danek Duvall added 4 commits August 3, 2017 14:55
This fixes a handful of long-failing tests.
This is a follow-up to ea23e50, which fixed it for the build.
This is a follow-up to f189d7a and 9d11b08.  While `-z ignore`
is what needs to be passed to the Solaris linker, because gcc is used as
the default linker, both that form and `-Wl,-z -Wl,ignore` (including
extra double quotes) need to be taken into account, which explains the
more complex regular expression.
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @BurntSushi (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sanxiyn
Copy link
Member

sanxiyn commented Aug 4, 2017

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 4, 2017

📌 Commit 9144755 has been approved by sanxiyn

@bors
Copy link
Collaborator

bors commented Aug 4, 2017

⌛ Testing commit 9144755 with merge 5431f42...

bors added a commit that referenced this pull request Aug 4, 2017
Fix a number of failing tests on Solaris and SPARC
@bors
Copy link
Collaborator

bors commented Aug 4, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: sanxiyn
Pushing 5431f42 to master...

@bors bors merged commit 9144755 into rust-lang:master Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants