Let HasAttrs return attributes for StmtKind::Item #43807
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
shepmaster
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 5e7dc36 has been approved by |
|
@bors r- Wait, I may know why this is so. |
| @@ -1291,7 +1291,7 @@ impl HasAttrs for StmtKind { | |||
| fn attrs(&self) -> &[Attribute] { | |||
| match *self { | |||
| StmtKind::Local(ref local) => local.attrs(), | |||
| StmtKind::Item(..) => &[], | |||
| StmtKind::Item(ref item) => item.attrs(), | |||
There was a problem hiding this comment.
What is this "fixing"? It may be the case that this change will result in the same attributes being seen twice.
Although it's in libsyntax. Where it might not even be used directly.
|
r? @jseyfried |
sinkuu
changed the title
|
I should have checked git history: b968ee3 |
Fixes
HasAttrsignoring attributes from item statements.