Allow consts to be initialized by non-nullary enum constructors #4459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loosening the connection between the LLVM type and the Rust type is necessary to use non-nullary enum constructors as const initializers, because the const needs to be initialized with data of the actual type of the variant in question, which is (generally) not the same as the u8 array in the `type_of` type. Thus, referring to a const now requires casting the LLVM global to the expected pointer type instead of using it as-is.
The tests have consts defined both before and after their uses in order to prevent bugs that depend on the order in which they are translated.
If the PointerCast in trans_def_lvalue is removed, these cases cause LLVM assertion failures.
catamorphism
added a commit
that referenced
this pull request
Jan 13, 2013
Allow consts to be initialized by non-nullary enum constructors
|
Good work, thanks! |
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2021
* Added test cases * Fixed if condition comment issue * Fixed extern C issue * Removed previous test case * Removed tmp file * honor the authors intent * Changed the file name to its original name * Removed extra whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.