Skip to content

Cleanly error for non-const variable in associated const #45442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2017
Merged

Cleanly error for non-const variable in associated const #45442

merged 1 commit into from
Oct 22, 2017

Conversation

matthewjasper
Copy link
Contributor

Not sure if wrapping the whole visit::walk_impl_item call is correct.
Closes #44239

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@petrochenkov
Copy link
Contributor

@bors r+
Thanks!

@bors
Copy link
Collaborator

bors commented Oct 22, 2017

📌 Commit 02635c2 has been approved by petrochenkov

@kennytm kennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 22, 2017
@bors
Copy link
Collaborator

bors commented Oct 22, 2017

⌛ Testing commit 02635c2 with merge fc1a03d...

bors added a commit that referenced this pull request Oct 22, 2017
@bors
Auto merge of #45442 - matthewjasper:const-dynamic-capture-error, r=p…
fc1a03d 
…etrochenkov

Cleanly error for non-const variable in associated const

Not sure if wrapping the whole `visit::walk_impl_item` call is correct.
Closes #44239
@bors
Copy link
Collaborator

bors commented Oct 22, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: petrochenkov
Pushing fc1a03d to master...

@bors bors merged commit 02635c2 into rust-lang:master Oct 22, 2017
@matthewjasper matthewjasper deleted the const-dynamic-capture-error branch October 22, 2017 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@arielb1 arielb1

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@matthewjasper @rust-highfive @petrochenkov @bors @kennytm @arielb1