Fix 32- vs 64-bit platform instability in StableHasher. #45522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielb1
reviewed
Oct 25, 2017
| @@ -132,8 +132,11 @@ impl<W> Hasher for StableHasher<W> { | |||
|
|
|||
There was a problem hiding this comment.
There's a comment that says
// For the non-u8 integer cases we leb128 encode them first. Because smalland another comment that says
/// At the moment, we pass i8/u8 straight through and encode
/// all other integers using leb128.
Please fix it
|
r=me with comments fixed |
kennytm
added
the
S-waiting-on-author
|
📌 Commit 54818b3 has been approved by |
kennytm
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 26, 2017
…ielb1 Fix 32- vs 64-bit platform instability in StableHasher. This might already be enough to fix issue #45500. r? @alexcrichton
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might already be enough to fix issue #45500.
r? @alexcrichton