Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The manual's
link
attribute example code did not compile! For new users that copy and paste example code (like I did), this is pretty frustrating. The master and 0.5 branches have the same doc bug. Since this is a small fix for a frustrating problem, you might consider cherry picking this fix to those branches.OpenSSL's
SHA1()
function takes asize_t
, according the Darwin and Linux header files. The FFI tutorial was inconsistently using bothuint
andlibc::c_uint
.Enable lint warnings for doc tests. I thought this would be a good way to ensure that the docs' example code uses the latest coding style. Is the big, multi-line """ ... """ string too ugly?
For lint warnings that many doc tests fail (e.g.
deprecated_self
,non_camel_case_types
,structural_records
), I just enabled them as#[ warn(...) ]
as a reminder to possiblyforbid
them in the future.Also fix some typos and remove some semicolons (!!) from the doc test generator Python script.