Skip to content

Reenable clippy #46402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2017
Merged

Reenable clippy #46402

merged 1 commit into from
Nov 30, 2017

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Nov 30, 2017

No description provided.

@rust-highfive
Copy link
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 30, 2017
@kennytm
Copy link
Member

kennytm commented Nov 30, 2017

Needs to update Cargo.lock.

[00:02:06] error: the lock file needs to be updated but --locked was passed to prevent this
[00:02:06] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:02:06] Build completed unsuccessfully in 0:00:18

@kennytm
Copy link
Member

kennytm commented Nov 30, 2017

@bors r+ p=2

@bors
Copy link
Collaborator

bors commented Nov 30, 2017

📌 Commit 208deac has been approved by kennytm

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2017
@bors
Copy link
Collaborator

bors commented Nov 30, 2017

⌛ Testing commit 208deac with merge 23032d0...

bors added a commit that referenced this pull request Nov 30, 2017
@bors
Auto merge of #46402 - oli-obk:clippy, r=kennytm
23032d0 
Reenable clippy
@bors
Copy link
Collaborator

bors commented Nov 30, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing 23032d0 to master...

@bors bors merged commit 208deac into rust-lang:master Nov 30, 2017
@arielb1
Copy link
Contributor

arielb1 commented Nov 30, 2017

Yay this passed appveyor with less than 10 minutes to spare. Could appveyor be more consistently fast or extend their timeout when theey are randomly slow?

@oli-obk oli-obk deleted the clippy branch December 8, 2017 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@oli-obk @rust-highfive @kennytm @bors @arielb1 @aturon