Update more uses of Option, Some and None to camel case #4644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compile fails for another reason, that triggers before the the failure for non-camel cased option, some or none undefined errors.
|
Great, thanks! |
catamorphism
added a commit
that referenced
this pull request
Jan 26, 2013
Update more uses of Option, Some and None to camel case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated most of the outstanding lowercase uses of Option, Some and None. I was inspired by the error message (corrected in 7ff7489) as it was slightly misleading.
There are still outstanding uses of the lowercase None. If this is useful, I'll go back and work through that list as well.
I haven't added any new regression tests. I wasn't sure they were appropriate in this case. Almost all of these changes are to places that the tests don't really cover: comments, xfailed tests and error and debug messages.
make check: summary of 23 test runs: 4252 passed; 0 failed; 280 ignored :)