Small fixes to code samples in Tutorials #4669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. The section on trait definitions of static methods should include
a trait with a static method in the generated document.
2. The section on trait inheritance had a expression that appears
nonsensical ("let mycircle = @Mycircle") in the generated document.
The text would be clearer (IMO) if we continued with the running
example of CircleStruct.
1. In the first case, the previous code was failing during type inference due to mismatched structure. Fix is to use the X structure at both points in the code. 2. In the second case, a naive transcription that subsitutes *nothing* in for the omitted statements signified by "..." will actually compile without an error. Furthermore, any pure code could also be substituted for the ellipsis and the code would compile (as the text already states). So to make the example more illustrative, it would be better to include an impure callback, which makes the potential for aliasing immediately obvious to the reader.
I had put a line break in to try to stress the binding of mycircle, but generated document looks cleaner without newline.
|
r+ -- @pnkfelix, do you have commit access to Rust, or do you want me to merge this for you for now? |
|
@catamorphism I do not have commit access to Rust. Please push for me. |
catamorphism
added a commit
that referenced
this pull request
Jan 30, 2013
Small fixes to code samples in Tutorials
|
Merged, and thanks! |
calebcartwright
pushed a commit
to calebcartwright/rust
that referenced
this pull request
Oct 20, 2021
This option merges all imports into a single `use` statement as long as they have the same visibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.