Skip to content

libsyntax: Implement the impl Trait for Type syntax #4675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 23 additions & 6 deletions src/libsyntax/parse/parser.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2791,8 +2791,9 @@ impl Parser {
(ident, item_trait(tps, traits, meths), None)
}

// Parses four variants (with the region/type params always optional):
// Parses two variants (with the region/type params always optional):
// impl<T> ~[T] : to_str { ... }
// impl<T> to_str for ~[T] { ... }
fn parse_item_impl() -> item_info {
fn wrap_path(p: Parser, pt: @path) -> @Ty {
@Ty {
Expand All @@ -2802,8 +2803,6 @@ impl Parser {
}
}

// We do two separate paths here: old-style impls and new-style impls.

// First, parse type parameters if necessary.
let mut tps;
if self.token == token::LT {
Expand All @@ -2816,14 +2815,32 @@ impl Parser {
// XXX: clownshoes
let ident = special_idents::clownshoes_extensions;

// Parse the type.
let ty = self.parse_ty(false);

// Parse the type. (If this is `impl trait for type`, however, this
// actually parses the trait.)
let mut ty = self.parse_ty(false);

// Parse traits, if necessary.
let opt_trait = if self.token == token::COLON {
// Old-style trait.
self.bump();
Some(self.parse_trait_ref())
} else if self.eat_keyword(~"for") {
// New-style trait. Reinterpret the type as a trait.
let opt_trait_ref = match ty.node {
ty_path(path, node_id) => {
Some(@trait_ref {
path: path,
ref_id: node_id
})
}
_ => {
self.span_err(copy self.span, ~"not a trait");
None
}
};

ty = self.parse_ty(false);
opt_trait_ref
} else {
None
};
Expand Down
26 changes: 26 additions & 0 deletions src/test/run-pass/new-impl-syntax.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
struct Thingy {
x: int,
y: int
}

impl ToStr for Thingy {
pure fn to_str() -> ~str {
fmt!("{ x: %d, y: %d }", self.x, self.y)
}
}

struct PolymorphicThingy<T> {
x: T
}

impl<T:ToStr> ToStr for PolymorphicThingy<T> {
pure fn to_str() -> ~str {
self.x.to_str()
}
}

fn main() {
io::println(Thingy { x: 1, y: 2 }.to_str());
io::println(PolymorphicThingy { x: Thingy { x: 1, y: 2 } }.to_str());
}