Skip to content

Libuv update #4794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 11, 2013
Merged

Libuv update #4794

merged 9 commits into from
Feb 11, 2013

Conversation

olsonjeffery
Copy link
Contributor

Want to get this on the radar and moving forward. I'm having build issues in mingw32, so I'll probably be troubleshooting from afar on that front.

This work mostly involves:

  • Updating the libuv submodule (which, in the scope of this pull req, is pointing at olsonjeffery/libuv, pending a merge into master from graydon (which is, itself, tricky)) with the last 9 months or so of changes from them (refcount refactor and numerous other codebase cleanups)
  • Retooling the build process a bit, doing away with a bunch of gnarly scripting and, for the most part, just using libuv's own Makefile, which is great
  • Minor updates to the API to account for the loss of uv_refcount, we now just do a check for any live handles during the weak task exit check in iotask, and barf if we encounter any lives tasks
  • Adjustment to the various libuv structs, whose size changed in the intervening time

Note on the last bullet: I want to turn another another patch, soon, to change the mechanism of libuv struct mapping to be dynamic and based off of malloc'd data wrapped in a rust wrapper to alleviate the headache of maintaining these structs across multiple platforms, as the libuv API exports stuff designed specifically for this purpose. The usual weighing of benefits/tradeoffs ensues.

@brson
Copy link
Contributor

brson commented Feb 5, 2013

\o/ Thanks @olsonjeffery

@graydon
Copy link
Contributor

graydon commented Feb 5, 2013

sent to try; I'm a little curious about the "CFLAGS had to stay" comment. CFLAGS was exactly the thing I had to remove for mingw to work.

@catamorphism
Copy link
Contributor

Since graydon said "sent to try" I'll go ahead and r+ this.

@olsonjeffery
Copy link
Contributor Author

Hey I had to do a forced update on my libuv branch.. I couldn't get stdtest to build on OSX, so I had to rebase against mozilla/incoming in order to get it to work.

On the plus side, I fixed the one libuv struct that was off on OSX and now stdtest passes, huzzah

@brson brson merged commit 4696fb3 into rust-lang:incoming Feb 11, 2013
@brson
Copy link
Contributor

brson commented Feb 11, 2013

Thanks, @olsonjeffery. That was a huge effort.

@olsonjeffery
Copy link
Contributor Author

Onward!
On Feb 11, 2013 12:56 PM, "Brian Anderson" [email protected] wrote:

Thanks, @olsonjeffery https://github.com/olsonjeffery. That was a huge
effort.


Reply to this email directly or view it on GitHubhttps://github.com//pull/4794#issuecomment-13402280.

@graydon
Copy link
Contributor

graydon commented Feb 11, 2013

applause thanks so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants