-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Libuv update #4794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Libuv update #4794
Conversation
\o/ Thanks @olsonjeffery |
sent to try; I'm a little curious about the "CFLAGS had to stay" comment. CFLAGS was exactly the thing I had to remove for mingw to work. |
- thanks to work in libuv's upstream, we can call libuv's Makefile directly with parameters, instead of descending in gyp-uv madness and generating our own.
…d libuv work on mingw
Since graydon said "sent to try" I'll go ahead and r+ this. |
Hey I had to do a forced update on my libuv branch.. I couldn't get stdtest to build on OSX, so I had to rebase against mozilla/incoming in order to get it to work. On the plus side, I fixed the one libuv struct that was off on OSX and now stdtest passes, huzzah |
Thanks, @olsonjeffery. That was a huge effort. |
Onward!
|
applause thanks so much |
Want to get this on the radar and moving forward. I'm having build issues in mingw32, so I'll probably be troubleshooting from afar on that front.
This work mostly involves:
uv_refcount
, we now just do a check for any live handles during the weak task exit check iniotask
, and barf if we encounter any lives tasksNote on the last bullet: I want to turn another another patch, soon, to change the mechanism of libuv struct mapping to be dynamic and based off of malloc'd data wrapped in a rust wrapper to alleviate the headache of maintaining these structs across multiple platforms, as the libuv API exports stuff designed specifically for this purpose. The usual weighing of benefits/tradeoffs ensues.