Add debug info tests #4798
Closed
Add debug info tests #4798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
swoon @bleibig, my hero! |
|
!!!!!!!!!!!!!!!!!!!!!!!! |
|
The reason the symbols aren't generated is that I hid anything beyond line number information behind the --xg flag. Variable symbol information tends to cause ICEs for non-trivial programs, since the full set of Rust types is not yet implemented. |
|
Unfortunately this has diverged from trunk a bit an can't be merged anymore; any chance you can refresh it? |
|
I'm not really the best with git and couldn't find a clean way to do that, so I just created a new pull request here. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 7, 2022
Add `crate_in_macro_def` lint This PR adds a lint to check for `crate` as opposed to `$crate` used in a macro definition. I think this can close rust-lang#4798. That issue focused on the case where the macro author "imports something into said macro." But I think use of `crate` is likely to be a bug whether it appears in a `use` statement or not. There could be some use case I am failing to see, though. (cc: `@nilscript` `@flip1995)` changelog: `crate_in_macro_def`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue 2195.
The testing procedure mimics the way clang/llvm does their debuginfo tests - it creates a debugging commands script from directives in the header file which gdb runs in batch mode with the executable, and then checks if output is as expected. I have two very simple tests included, and they're both ignored because rust doesn't seem to emit good enough symbols for them to pass (by the way, I'll see if I can help fix that).
Note that once debug info tests are enabled, gdb will become a dependency for 'make check'.