incr.comp.: Make sanity check in try_mark_green() aware of error conditions. #49088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ p=1 Assigning high priority as this is a regression fix. |
|
📌 Commit ee4a7eb has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit ee4a7eb with merge 7abe916c741e9da9c4334c6ed24473cf29eef6df... |
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
|
@bors: retry another appveyor timeout... |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Mar 17, 2018
incr.comp.: Make sanity check in try_mark_green() aware of error conditions. Before this PR, `DepGraph::try_mark_green()` assumed that forcing a query would always set the color of the corresponding dep-node. However, it did not take into account that queries could also fail (e.g. with a cycle error). This PR makes the method handle that condition gracefully. Fixes #49070. r? @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR,
DepGraph::try_mark_green()assumed that forcing a query would always set the color of the corresponding dep-node. However, it did not take into account that queries could also fail (e.g. with a cycle error). This PR makes the method handle that condition gracefully.Fixes #49070.
r? @nikomatsakis