Handle fast-submodules option correctly #49527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option was introduced in 72cb109, but it uses two different spellings (fast-submodule vs fast-submodules) and isn't handled by Rust bootstrap which means that any attempt to set this flag fails.
|
@bors: r+ Thanks! |
|
📌 Commit a24811e has been approved by |
bors
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Apr 1, 2018
Handle fast-submodules option correctly This option was introduced in 72cb109, but it uses two different spellings (`fast-submodule` in `bootstrap.py` vs `fast-submodules` in `config.toml.example`) and isn't handled by Rust bootstrap which means that any attempt to set this flag fails.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option was introduced in 72cb109, but it uses two different
spellings (
fast-submoduleinbootstrap.pyvsfast-submodulesinconfig.toml.example) and isn't handled by Rust bootstrap which meansthat any attempt to set this flag fails.