typo fix in doc/rust.md #5027
Closed
typo fix in doc/rust.md #5027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this isn't actually calloc - it calls the malloc wrapper which no longer zeroes
it doesn't actually call calloc, so it's fairly pointless
… r=brson review? @brson Issue rust-lang#4524
Rename const_view to const_slice Renamed mut_view to mut_slice
…=catamorphism This is a natural extension of rust-lang#4887, and handles the following three cases: ~~~~ a line with only /s //////////////////////////////////////////// a line with only /s followed by whitespace //////////////////////////////////////////// a block comment with only *s between two /s /********************************/ ~~~~
I removed the unused wrappers methods named `calloc` because they relied on the malloc wrapper having a `bool zero = true` default parameter (which resulted in some accidental zeroing). Perhaps wrapping the actual calloc function would be useful, but I don't know of an existing use case that could use it so I just removed these. This gives an ~1% performance improvement for TreeMap, which does a lot of small allocations. Vectors use `realloc` which didn't zero before these changes so there's no measurable change in performance.
Removed hacky dependency on Round trait and generic infinity functions Removed generic-runtime-failure-depending-on-type behavior
Updated the rustc manpage based on the usage message for 0.6 (including -Z options). Also added an example showing how to compile with debug info. This targets incoming rather than master. rust-lang#4936 can be closed.
...locking-servo `simplify_type` was bogus, as there was no way for it to handle enums properly. It was also slow, because it created many Rust types at runtime. In general creating Rust types during trans is a source of slowness, and I'd like to avoid doing it as much as possible. (It is probably not possible to eliminate it entirely, due to `subst`, but we should get rid of as much of it as we can.) So this patch replaces `simplify_type` with `sizing_type_of`, which creates a size-equivalent LLVM type directly without going through a Rust type first. Because this is causing an ICE in Servo, I'm rubber stamping it.
```rust
#[cfg(target_endian = "little")]
fn something() { /* .. */ }
#[cfg(target_endian = "big")]
fn something() { /* .. */ }
```
* use a proper exported data type with private fields * implement core::container::Container * use the current constructor convention * use explicit self * get rid of DVec and the mutable fields Closes rust-lang#2343
… r=graydon Remove capture clause use. I think I got them all.
…ctly. Consts of such enums are aligned correctly, so we could either misalign them to match the type_of, or fix the type_of. The latter seems like a better idea.
|
Sorry to fuss for such a small pull req, but can you re-target it against the master branch? Thanks :-) |
|
I'm not sure how. I thought it was against the master branch. Or do you mean target it against incoming? |
|
Oops, sorry -- yes, I meant target it against incoming. https://github.com/mozilla/rust/wiki/Note-development-policy under "Pull request procedure" says how. |
|
You'll have to give me a minute to figure out how git branching works :) |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 2, 2020
Lint vectored IO in unused_io_amount lint `read_vectored` & `write_vectored` require handling returned value likewise non-vectored methods. rust-lang#68041 --- changelog: lint vectored IO in `unused_io_amount` lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The smallest possible pull request: Adding a single byte!
The header is malformed because it lacks a preceding newline.