use reset_unifications instead of creating new unification table
#50874
+7
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r me once travis is happy |
|
@bors r=estebank I'm that confident. |
|
📌 Commit 7ed0fd7 has been approved by |
bors
added
S-waiting-on-bors
|
@bors p=1 I'm bumping the priority here because NLL is kinda' important and it's really useful to have the feedback from perf. (I'm of course profiling locally, but it's sometimes hard to translate results.) |
bors
added a commit
that referenced
this pull request
May 19, 2018
use `reset_unifications` instead of creating new unification table This eliminates a hot spot in NLL performance.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates a hot spot in NLL performance.