Document size_of for 128-bit integers #51441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We might want to consider separately documenting the alignment of primitives, rather than just their size, since 128-bit integers, unlike all other primitives, have an alignment that is not identical to their size (size_of is 16, align_of is 8)
|
64 bit integers also sometimes have alignment 4. There's no real pattern there, it's just that usually native word sizes should be naturally aligned. |
kennytm
added
the
S-waiting-on-review
|
r? @dtolnay |
dtolnay
approved these changes
Jun 9, 2018
|
@bors r+ rollup |
|
📌 Commit 9a8fa2c has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jun 9, 2018
Document size_of for 128-bit integers We might want to consider separately documenting the alignment of primitives, rather than just their size, since 128-bit integers, unlike all other primitives, have an alignment that is not identical to their size (size_of is 16, align_of is 8)
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We might want to consider separately documenting the alignment of
primitives, rather than just their size, since 128-bit integers, unlike
all other primitives, have an alignment that is not identical to their
size (size_of is 16, align_of is 8)