Skip to content

rustc_codegen_llvm: don't treat i1 as signed, even for #[repr(i8)] enums. #51594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2018

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Jun 16, 2018

Fixes #51582. r? @nagisa cc @nox @oli-obk

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 16, 2018
@nagisa
Copy link
Member

nagisa commented Jun 16, 2018

@bors r+

Nasty.

@bors
Copy link
Collaborator

bors commented Jun 16, 2018

📌 Commit 25c47a4 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 16, 2018
@bors
Copy link
Collaborator

bors commented Jun 16, 2018

⌛ Testing commit 25c47a4 with merge ae46aef...

bors added a commit that referenced this pull request Jun 16, 2018
rustc_codegen_llvm: don't treat i1 as signed, even for #[repr(i8)] enums.

Fixes #51582. r? @nagisa cc @nox @oli-obk
@bors
Copy link
Collaborator

bors commented Jun 16, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nagisa
Pushing ae46aef to master...

@bors bors merged commit 25c47a4 into rust-lang:master Jun 16, 2018
@eddyb eddyb deleted the issue-51582 branch June 17, 2018 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants