Skip to content

mir-opt: Make SimplifyCfg collapse goto chains starting from bb0 #56764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2018

Conversation

sinkuu
Copy link
Contributor

@sinkuu sinkuu commented Dec 13, 2018

SimplifyCfg pass was not able to collapse goto chains starting from bb0, leaving MIR like this:

bb0: {
    goto -> bb1;
}

@rust-highfive
Copy link
Contributor

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 13, 2018
Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Lgtm but I'd like somebody else to review as well.

@matthewjasper
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 16, 2018

📌 Commit 83298a2 has been approved by matthewjasper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2018
@bors
Copy link
Collaborator

bors commented Dec 17, 2018

⌛ Testing commit 83298a2 with merge 7fb479c...

bors added a commit that referenced this pull request Dec 17, 2018
mir-opt: Make SimplifyCfg collapse goto chains starting from bb0

`SimplifyCfg` pass was not able to collapse goto chains starting from bb0, leaving MIR like this:

```
bb0: {
    goto -> bb1;
}
```
@bors
Copy link
Collaborator

bors commented Dec 17, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: matthewjasper
Pushing 7fb479c to master...

@bors bors merged commit 83298a2 into rust-lang:master Dec 17, 2018
@sinkuu sinkuu deleted the simpcfg_bb0 branch December 17, 2018 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants