Fix unicode tables #5945
Merged
Fix unicode tables #5945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Returns the index where the comparator returned `Equal`, or `None` if | ||
| * not found. | ||
| */ | ||
| pub fn bsearch<T>(v: &[T], f: &fn(&T) -> Ordering) -> Option<uint> { |
There was a problem hiding this comment.
In Haskell this is called bsearch_by and the other is called bsearch. Should we follow that convention?
bors
added a commit
that referenced
this pull request
Apr 20, 2013
This switches the unicode functions in core to use static character-range tables and a binary search helper rather than open-coded switch statements. It adds about 50k of read only data to the libcore binary but cuts out a similar amount of compiled IR. Would have done it this way in the first place but we didn't have structured statics for a long time.
|
@graydon, do you think it would be a good idea to write an additional line |
|
Oh, probably, yeah. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 9, 2020
…ion_in_needless_range_loop, r=flip1995 Don't emit a lint for the suggestion leading to errors in `needless_range_loop` Fix rust-lang#5945 changelog: Don't emit a lint for the suggestion leading to errors in `needless_range_loop`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the unicode functions in core to use static character-range tables and a binary search helper rather than open-coded switch statements. It adds about 50k of read only data to the libcore binary but cuts out a similar amount of compiled IR. Would have done it this way in the first place but we didn't have structured statics for a long time.