Skip to content

Do not mention missing PartialOrd impl when involving uncalled fns #60051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 18, 2019
Merged

Do not mention missing PartialOrd impl when involving uncalled fns #60051

merged 2 commits into from
Apr 18, 2019

Conversation

estebank
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 17, 2019
@estebank
Copy link
Contributor Author

r? @davidtwco

@rust-highfive rust-highfive assigned davidtwco and unassigned pnkfelix Apr 17, 2019
davidtwco
davidtwco requested changes Apr 17, 2019
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor comment.

@estebank
Copy link
Contributor Author

@bors r=davidtwco

@bors
Copy link
Collaborator

bors commented Apr 18, 2019

📌 Commit 84af684 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2019
@estebank
Copy link
Contributor Author

@bors rollup

@bors
Copy link
Collaborator

bors commented Apr 18, 2019

⌛ Testing commit 84af684 with merge fb1b222...

bors added a commit that referenced this pull request Apr 18, 2019
@bors
Auto merge of #60051 - estebank:fn-sugg, r=davidtwco
fb1b222 
Do not mention missing `PartialOrd` impl when involving uncalled fns
@bors
Copy link
Collaborator

bors commented Apr 18, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: davidtwco
Pushing fb1b222 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 18, 2019
@bors bors merged commit 84af684 into rust-lang:master Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco requested changes

Assignees

@davidtwco davidtwco

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@estebank @rust-highfive @bors @davidtwco @pnkfelix