-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Detect tuple struct incorrectly used as struct pat #74173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
A tuple struct or tuple variant was used in a pattern as if it were a | ||
struct or struct variant. | ||
|
||
Erroneous code example: | ||
|
||
```compile_fail,E0769 | ||
enum E { | ||
A(i32), | ||
} | ||
let e = E::A(42); | ||
match e { | ||
E::A { number } => println!("{}", x), | ||
} | ||
``` | ||
|
||
To fix this error, you can use the tuple pattern: | ||
|
||
``` | ||
# enum E { | ||
# A(i32), | ||
# } | ||
# let e = E::A(42); | ||
match e { | ||
E::A(number) => println!("{}", number), | ||
} | ||
``` | ||
|
||
Alternatively, you can also use the struct pattern by using the correct | ||
field names and binding them to new identifiers: | ||
|
||
``` | ||
# enum E { | ||
# A(i32), | ||
# } | ||
# let e = E::A(42); | ||
match e { | ||
E::A { 0: number } => println!("{}", number), | ||
} | ||
``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 4 additions & 13 deletions
17
src/test/ui/missing/missing-fields-in-struct-pattern.stderr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,9 @@ | ||
error[E0026]: struct `S` does not have fields named `a`, `b`, `c`, `d` | ||
--> $DIR/missing-fields-in-struct-pattern.rs:4:16 | ||
| | ||
LL | if let S { a, b, c, d } = S(1, 2, 3, 4) { | ||
| ^ ^ ^ ^ struct `S` does not have these fields | ||
|
||
error[E0027]: pattern does not mention fields `0`, `1`, `2`, `3` | ||
error[E0769]: tuple variant `S` written as struct variant | ||
--> $DIR/missing-fields-in-struct-pattern.rs:4:12 | ||
| | ||
LL | if let S { a, b, c, d } = S(1, 2, 3, 4) { | ||
| ^^^^^^^^^^^^^^^^ missing fields `0`, `1`, `2`, `3` | ||
| | ||
= note: trying to match a tuple variant with a struct variant pattern | ||
| ^^^^^^^^^^^^^^^^ help: use the tuple variant pattern syntax instead: `S(a, b, c, d)` | ||
|
||
error: aborting due to 2 previous errors | ||
error: aborting due to previous error | ||
|
||
Some errors have detailed explanations: E0026, E0027. | ||
For more information about an error, try `rustc --explain E0026`. | ||
For more information about this error, try `rustc --explain E0769`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,9 @@ | ||
error[E0026]: variant `X::Y` does not have a field named `number` | ||
--> $DIR/issue-41314.rs:7:16 | ||
| | ||
LL | X::Y { number } => {} | ||
| ^^^^^^ variant `X::Y` does not have this field | ||
|
||
error[E0027]: pattern does not mention field `0` | ||
error[E0769]: tuple variant `X::Y` written as struct variant | ||
--> $DIR/issue-41314.rs:7:9 | ||
| | ||
LL | X::Y { number } => {} | ||
| ^^^^^^^^^^^^^^^ missing field `0` | ||
| | ||
= note: trying to match a tuple variant with a struct variant pattern | ||
| ^^^^^^^^^^^^^^^ help: use the tuple variant pattern syntax instead: `X::Y(number)` | ||
|
||
error: aborting due to 2 previous errors | ||
error: aborting due to previous error | ||
|
||
Some errors have detailed explanations: E0026, E0027. | ||
For more information about an error, try `rustc --explain E0026`. | ||
For more information about this error, try `rustc --explain E0769`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.