librustc_typeck: use diag item instead of string compare #74471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @eddyb |
da-x
force-pushed
the
string-type-diagnostic-item
branch
from
fe1e6f5 to
0c86bbc
Compare
da-x
force-pushed
the
string-type-diagnostic-item
branch
from
0c86bbc to
28e2756
Compare
lcnr
approved these changes
Jul 18, 2020
Co-authored-by: Bastian Kauschke <[email protected]>
|
@bors r+ |
|
📌 Commit d077767 has been approved by |
bors
added
S-waiting-on-bors
| let is_std_string = |ty: Ty<'tcx>| match ty.ty_adt_def() { | ||
| Some(ty_def) => Some(ty_def.did) == string_type, | ||
| None => false, | ||
| }; |
There was a problem hiding this comment.
You could also use map_or here though.
ty.ty_adt_def().map_or(false, |adt_def| Some(adt_def.did) == string_type)
|
☀️ Test successful - checks-actions, checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.