Skip to content

report kind of deprecated item in message #74785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2020

Conversation

euclio
Copy link
Contributor

@euclio euclio commented Jul 26, 2020

This is important for fields, which are incorrectly referred to as
"items".

@rust-highfive
Copy link
Contributor

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 26, 2020
This is important for fields, which are incorrectly referred to as
"items".
@euclio euclio force-pushed the deprecation-kinds branch from 04d2f9b to 0b32008 Compare July 26, 2020 17:59
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 27, 2020

📌 Commit 0b32008 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 27, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 27, 2020
…enkov

report kind of deprecated item in message

This is important for fields, which are incorrectly referred to as
"items".
@JohnTitor
Copy link
Member

Seems failed in rollup: #74810 (comment)
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 27, 2020
bors added a commit to rust-lang/cargo that referenced this pull request Jul 31, 2020
relax deprecated diagnostic message check

Needed to unblock rust-lang/rust#74785.
@euclio
Copy link
Contributor Author

euclio commented Aug 1, 2020

This is ready for another try now that #74996 is merged.

@JohnTitor
Copy link
Member

@bors r=petrochenkov

@bors
Copy link
Collaborator

bors commented Aug 1, 2020

📌 Commit 0b32008 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 1, 2020
@bors
Copy link
Collaborator

bors commented Aug 2, 2020

⌛ Testing commit 0b32008 with merge 8141873...

@bors
Copy link
Collaborator

bors commented Aug 2, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: petrochenkov
Pushing 8141873 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 2, 2020
@bors bors merged commit 8141873 into rust-lang:master Aug 2, 2020
@euclio euclio deleted the deprecation-kinds branch August 2, 2020 14:56
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants