Skip to content

Switch to intra-doc links in core::option #75541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 16, 2020
Merged

Switch to intra-doc links in core::option #75541

merged 3 commits into from
Aug 16, 2020

Conversation

camelid
Copy link
Member

@camelid camelid commented Aug 14, 2020 •
edited
Loading

Part of #75080.

I didn't change some of the links since they link into std and you can't link from core to std (#74481).

Also, at least one other link can't be switched to an intra-doc link because it's not supported yet (#74489).

@rust-highfive
Copy link
Contributor

r? @KodrAus

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 14, 2020
camelid
camelid commented Aug 14, 2020
View reviewed changes
@jyn514 jyn514 added A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 15, 2020
@camelid
Fix link
b02c404 
Intra-doc links don't work yet in this case: rust-lang#74489
jyn514
jyn514 reviewed Aug 15, 2020
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after nit is fixed

camelid
camelid commented Aug 15, 2020
View reviewed changes
@jyn514
Copy link
Member

jyn514 commented Aug 15, 2020

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 15, 2020

📌 Commit 8227b3b has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2020
@bors
Copy link
Collaborator

bors commented Aug 16, 2020

⌛ Testing commit 8227b3b with merge 86bccb6...

@bors
Copy link
Collaborator

bors commented Aug 16, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: jyn514
Pushing 86bccb6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 16, 2020
@bors bors merged commit 86bccb6 into rust-lang:master Aug 16, 2020
@jyn514 jyn514 removed the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Aug 25, 2020
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

Assignees

@KodrAus KodrAus

Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
6 participants
@camelid @rust-highfive @jyn514 @bors @cuviper @KodrAus