Move to intra-doc links for /library/core/src/char/convert.rs #75553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-intra-doc-links
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
jyn514
reviewed
Aug 15, 2020
library/core/src/char/convert.rs
Outdated
Comment on lines
26
to
27
| /// [`char`]: crate::char | ||
| /// [`u32`]: crate::u32 |
There was a problem hiding this comment.
You meant to link to the primitives, not the modules, I think.
Suggested change
| /// [`char`]: crate::char | |
| /// [`u32`]: crate::u32 |
(and also remove the trailing newline above, github won't let me add suggestions through deleted lines)
library/core/src/char/convert.rs
Outdated
Comment on lines
75
to
76
| /// [`char`]: crate::char | ||
| /// [`u32`]: crate::u32 |
There was a problem hiding this comment.
Suggested change
| /// [`char`]: crate::char | |
| /// [`u32`]: crate::u32 |
(and remove trailing newline)
|
r? @jyn514 |
|
@bors r+ rollup |
|
📌 Commit 14b50ed has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions, checks-azure |
jyn514
removed
the
T-rustdoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with #75080.
@rustbot modify labels: T-doc, A-intra-doc-links, T-rustdoc