Refactor intra doc link code #76684
Merged
Refactor intra doc link code #76684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `resolve` would immediately check that `module_id` was non-empty and give an error if not. This had two downsides: - It introduced `Option`s everywhere, even if the calling function knew it had a valid module, and - It checked the module on each namespace, which is unnecessary: it only needed to be checked once. This makes the caller responsible for checking the module exists, making the code a lot simpler.
jyn514
added
C-cleanup
|
Some changes occurred in intra-doc-links. cc @jyn514 |
rust-highfive
added
the
S-waiting-on-review
|
The number of parameters is kind of awful ... I might add a struct that groups them into one. |
Yeah no this had way too many compile errors for me to deal with right now, if I do add it will be in a follow-up PR |
Manishearth
reviewed
Sep 13, 2020
| } | ||
| } | ||
| } | ||
| match self.resolve_with_disambiguator( |
There was a problem hiding this comment.
This returns (), not Option. So it can't use ?.
|
@bors r=manishearth Note to anyone making rollups: this is unlikely to fail any tests, but is extremely likely to conflict with other intra-doc link PRs. |
|
📌 Commit 8a13fc4 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions, checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got tired of
fold_itembeing 500 lines long.This is best reviewed one commit at a time with whitespace changes hidden.
There are no logic changes other than the last commit making a parameter checked by the caller instead of the callee.
r? @Manishearth