Use correct article in help message for conversion or cast #77278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
camelid
added
A-diagnostics
camelid
commented
Sep 27, 2020
Before it always used `an`; now it uses the correct article for the type.
camelid
force-pushed
the
use-correct-article
branch
from
186893d to
549f861
Compare
estebank
reviewed
Sep 28, 2020
Also added missing backtick in "you can cast" message.
|
The wording for this kind of bothers me: I think it might sound better as "if the converted value doesn't fit". I think "wouldn't" to me makes it sound like it's a compile-time thing, but it's not. Can I change it? EDIT: I changed it. Let me know if I should change it back. |
|
@estebank Could you re-review this sometime soon? It would be nice to get this in before the release. But if you're not able to soon, I understand! |
jyn514
added
the
T-compiler
It felt too harsh to estebank and others to ICE even though it's technically a mistake to show a `TyKind::Error`.
|
looks good to me @bors r=estebank rollup |
|
📌 Commit 3eab21e has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions, checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before it always used
an; now it uses the correct article for the type.