Lots of default method and trait fixes #8015
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve vtable resolution in a handful of ways. First, if we don't find a vtable for a self/param type, do a regular vtable search. This could find impls of the form "impl for A". Second, we don't require that types be fully resolved before looking up subtables, and we process tables in reverse order. This allows us to gain more information about early type parameters based on how they are used by the impls used to resolve later params. Closes rust-lang#6967, I believe.
…data. Partially rework how vtables are handled in default method calls. Closes rust-lang#7460.
Eliminates method_super, method_self, and vtable_self, merging all of them into the param cases. Cloes rust-lang#4396. Closes rust-lang#7301.
|
Exciting. |
bors
added a commit
that referenced
this pull request
Jul 25, 2013
Lots of changes to vtable resolution, handling of super/self method calls in default methods. Fix a lot of trait inheritance bugs. r? @nikomatsakis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of changes to vtable resolution, handling of super/self method calls in default methods. Fix a lot of trait inheritance bugs.
r? @nikomatsakis