Skip to content

Miscellaneous inlining improvements #82559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2021
Merged

Miscellaneous inlining improvements #82559

merged 1 commit into from
Feb 27, 2021

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Feb 26, 2021

Inline a few small and hot functions.

Inline a few small and hot functions.
@rust-highfive
Copy link
Contributor

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 26, 2021
@tmiasko
Copy link
Contributor Author

tmiasko commented Feb 26, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 26, 2021
@bors
Copy link
Collaborator

bors commented Feb 26, 2021

⌛ Trying commit 481e1fd with merge 6dc1ac2467889dc8582289112bf067b3dc68de9e...

@bors
Copy link
Collaborator

bors commented Feb 26, 2021

☀️ Try build successful - checks-actions
Build commit: 6dc1ac2467889dc8582289112bf067b3dc68de9e (6dc1ac2467889dc8582289112bf067b3dc68de9e)

@rust-timer
Copy link
Collaborator

Queued 6dc1ac2467889dc8582289112bf067b3dc68de9e with parent cecdb18, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (6dc1ac2467889dc8582289112bf067b3dc68de9e): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 26, 2021
@petrochenkov
Copy link
Contributor

Nice.
@bors r+

@tmiasko
How did you find these?
I thought everything that is small and showed as hot by perf was already inlined long ago.

@bors
Copy link
Collaborator

bors commented Feb 26, 2021

📌 Commit 481e1fd has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2021
@bors
Copy link
Collaborator

bors commented Feb 26, 2021

⌛ Testing commit 481e1fd with merge 3da2dd3...

@bors
Copy link
Collaborator

bors commented Feb 27, 2021

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 3da2dd3 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 27, 2021
@bors bors merged commit 3da2dd3 into rust-lang:master Feb 27, 2021
@rustbot rustbot added this to the 1.52.0 milestone Feb 27, 2021
@tmiasko
Copy link
Contributor Author

tmiasko commented Feb 27, 2021

@petrochenkov I was looking at some perf reports and noticed those. Exposed by code refactoring most likely, given that each individually doesn't amount to much, easy to miss when no one is looking.

@tmiasko tmiasko deleted the inlined branch February 27, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants