Add frequency count to extra::stat. #8281 #8320
Conversation
| None => 1 | ||
| } | ||
| }; | ||
| map.insert(elem, to_insert); |
There was a problem hiding this comment.
I feel like from 362 to here could be map.insert_or_update_with(elem, 1, |_, count| *count += 1), but I'm not sure.
There was a problem hiding this comment.
I felt this was more readable but I have no problem of changing it, let me know about a final decision :).
There was a problem hiding this comment.
Using insert_or_update_with means that elem is only hashed once, so it will be approximately 2 times faster. You could write it as
do map.insert_or_update_with(elem, 1) |_, count| {
*count += 1;
}if you felt that was more readable.
|
@cmr should probably take a look at this (he was the one who opened the issue originally). Also, would you mind rebasing into a single commit? |
|
Sure, will do after there are no more changes to be made. |
|
@alexcrichton indeed, Clone was not needed. Thanks! |
|
Hi @mihneadb, This looks good! Can you squash the commits now? |
|
@cmr sure, done. :) Thanks! |
No description provided.