Skip to content

Reorder the parameter descriptions of map_or and map_or_else #84609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2021
Merged

Reorder the parameter descriptions of map_or and map_or_else #84609

merged 1 commit into from
Apr 27, 2021

Conversation

lefth
Copy link
Contributor

@lefth lefth commented Apr 27, 2021

They were described backwards, probably leading users to write arguments in the wrong order. Bug: #84608

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @yaahc (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 27, 2021
@Dylan-DPC-zz
Copy link

r? @Dylan-DPC

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 27, 2021

📌 Commit 6c22b39 has been approved by Dylan-DPC

@rust-highfive rust-highfive assigned Dylan-DPC-zz and unassigned yaahc Apr 27, 2021
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2021
@bors
Copy link
Collaborator

bors commented Apr 27, 2021

⌛ Testing commit 6c22b39 with merge 1919b3f...

@bors
Copy link
Collaborator

bors commented Apr 27, 2021

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing 1919b3f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 27, 2021
@bors bors merged commit 1919b3f into rust-lang:master Apr 27, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 27, 2021
@jyn514 jyn514 mentioned this pull request Apr 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Dylan-DPC-zz Dylan-DPC-zz

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lefth @rust-highfive @Dylan-DPC-zz @bors @yaahc @rustbot