Add .clang-format and run clang-format -i *.cpp #84889
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to me the original intent of the code style of the
LLVM wrapper was to follow the LLVM format. However, code style has
gotten a bit inconsistent inside the files. Thus, we add a
.clang-format file that indicates that the LLVM format is followed,
and run clang-format -i *.cpp on the files.
I file this PR as a request-for-comment. Please suggest some other code style if you prefer it.
clang-format
has a rich set of configuration options.Also I wonder if CI should enforce this. It's easy to do, one just has to run
clang-format --dry-run --Werror *.cpp
in thellvm-wrapper
directory. Should it maybe be added to tidy?