Skip to content

Retain data in vectorized registers for longer #84915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2021

Conversation

Mark-Simulacrum
Copy link
Member

This seems to be a mild performance improvement on the keccak crate at least, though not sure it'll show up more broadly.

@rust-highfive
Copy link
Contributor

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 4, 2021
@Mark-Simulacrum
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 4, 2021
@bors
Copy link
Collaborator

bors commented May 4, 2021

⌛ Trying commit 9d4c094 with merge 6ba031c17c0091086a5727f4ccee9690f10b7286...

@bors
Copy link
Collaborator

bors commented May 4, 2021

☀️ Try build successful - checks-actions
Build commit: 6ba031c17c0091086a5727f4ccee9690f10b7286 (6ba031c17c0091086a5727f4ccee9690f10b7286)

@rust-timer
Copy link
Collaborator

Queued 6ba031c17c0091086a5727f4ccee9690f10b7286 with parent a5f164f, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (6ba031c17c0091086a5727f4ccee9690f10b7286): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 4, 2021
@Mark-Simulacrum
Copy link
Member Author

Slight, but across the board wins, I think.

@jackh726
Copy link
Member

jackh726 commented May 4, 2021

🤷‍♀️ neat trick, decent comment, solid (albeit small) wins

@bors r+

@bors
Copy link
Collaborator

bors commented May 4, 2021

📌 Commit 9d4c094 has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2021
@bors
Copy link
Collaborator

bors commented May 5, 2021

⌛ Testing commit 9d4c094 with merge 45ccf91...

@bors
Copy link
Collaborator

bors commented May 5, 2021

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 45ccf91 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 5, 2021
@bors bors merged commit 45ccf91 into rust-lang:master May 5, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 5, 2021
@Mark-Simulacrum Mark-Simulacrum deleted the bitset-xor-eq branch May 8, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants