Skip to content

Fix uninhabited enum branching pass #85603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2021

Conversation

ogoffart
Copy link
Contributor

when the discriminant is taken with some projection.

@rust-highfive
Copy link
Contributor

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 23, 2021
@ogoffart
Copy link
Contributor Author

The context behind this PR is that I wanted to experiment with another optimisation on enums, and wanted to use this pass as a model. But I realized it did not match for most of the enums, so I needed to fix that first.

@crlf0710 crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2021
@jackh726
Copy link
Member

I don't know enough about this code to review this myself, but this also seems small. Let's r? @wesleywiser though.

@wesleywiser
Copy link
Member

Let's check performance before merging:

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 25, 2021
@bors
Copy link
Collaborator

bors commented Jun 25, 2021

⌛ Trying commit 5bece28 with merge dc41536a2e921160a1eeec16d307b49046e400a0...

@bors
Copy link
Collaborator

bors commented Jun 25, 2021

☀️ Try build successful - checks-actions
Build commit: dc41536a2e921160a1eeec16d307b49046e400a0 (dc41536a2e921160a1eeec16d307b49046e400a0)

@rust-timer
Copy link
Collaborator

Queued dc41536a2e921160a1eeec16d307b49046e400a0 with parent d4e7cb3, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (dc41536a2e921160a1eeec16d307b49046e400a0): comparison url.

Summary: This benchmark run did not return any significant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot
Copy link
Collaborator

rustbot commented Jun 25, 2021

Error: Label perf-regression can only be set by Rust team members

Please let @rust-lang/release know if you're having trouble with this bot.

@wesleywiser
Copy link
Member

cc @rust-lang/release rust-timer can't seem to set labels anymore

@wesleywiser
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Jun 25, 2021

📌 Commit 5bece28 has been approved by wesleywiser

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2021
@XAMPPRocky XAMPPRocky added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jun 25, 2021
@XAMPPRocky XAMPPRocky added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 25, 2021
@bors
Copy link
Collaborator

bors commented Jun 25, 2021

⌛ Testing commit 5bece28 with merge f726dbe...

@bors
Copy link
Collaborator

bors commented Jun 25, 2021

☀️ Test successful - checks-actions
Approved by: wesleywiser
Pushing f726dbe to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 25, 2021
@bors bors merged commit f726dbe into rust-lang:master Jun 25, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants