-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Fix uninhabited enum branching pass #85603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix uninhabited enum branching pass #85603
Conversation
…ectly If there is a projection on the place of the discriminent, the pass wouldn't trigger
r? @jackh726 (rust-highfive has picked a reviewer for you, use r? to override) |
The context behind this PR is that I wanted to experiment with another optimisation on enums, and wanted to use this pass as a model. But I realized it did not match for most of the enums, so I needed to fix that first. |
I don't know enough about this code to review this myself, but this also seems small. Let's r? @wesleywiser though. |
Let's check performance before merging: @bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 5bece28 with merge dc41536a2e921160a1eeec16d307b49046e400a0... |
☀️ Try build successful - checks-actions |
Queued dc41536a2e921160a1eeec16d307b49046e400a0 with parent d4e7cb3, future comparison URL. |
Finished benchmarking try commit (dc41536a2e921160a1eeec16d307b49046e400a0): comparison url. Summary: This benchmark run did not return any significant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
Error: Label perf-regression can only be set by Rust team members Please let |
cc @rust-lang/release |
@bors r+ rollup=never |
📌 Commit 5bece28 has been approved by |
☀️ Test successful - checks-actions |
when the discriminant is taken with some projection.