Skip to content

fix for #8088 #8573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix for #8088 #8573

wants to merge 1 commit into from

Conversation

minhnhdo
Copy link
Contributor

fix for #8088, along with a test.

@Aatch
Copy link
Contributor

Aatch commented Aug 17, 2013

I don't think this is the correct fix. That syntax is very old and there is newer, obsolete, syntax that doesn't have any obsolete detection. Just deleting the obsolete syntax detection for it is fine.

@kemurphy
Copy link
Contributor

== @Aatch

@minhnhdo
Copy link
Contributor Author

@kemurphy there exists a compile-fail test for this already. It's in src/test/compile-fail/obsolete.rs.

// ...
struct s {
    let foo: (),
    //~^ ERROR obsolete syntax: `let` in field declaration
    bar: ();
    //~^ ERROR obsolete syntax: field declaration terminated with semicolon
    new() { }
    //~^ ERROR obsolete syntax: struct constructor
}
// ...

@minhnhdo
Copy link
Contributor Author

@Aatch so you also want to just delete the pieces of code that deals with this?

@kemurphy
Copy link
Contributor

Yes, just cut it away entirely.

@minhnhdo
Copy link
Contributor Author

@kemurphy and the test also?

remove code for parsing ancient syntax
added a run-pass test
@alexcrichton
Copy link
Member

r+, man that is some seriously ancient syntax. Thanks!

@kemurphy
Copy link
Contributor

Looks good to me.

bors added a commit that referenced this pull request Aug 21, 2013
@bors bors closed this Aug 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants