Skip to content

Account for self.extra in size_hint for EncodeWide #86463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2021
Merged

Account for self.extra in size_hint for EncodeWide #86463

merged 1 commit into from
Jun 20, 2021
+14 −1

Conversation

fee1-dead
Copy link
Member

Fixes #86414.

@rust-highfive
Copy link
Contributor

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 19, 2021
@m-ou-se
Copy link
Member

m-ou-se commented Jun 19, 2021

Thank you!

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 19, 2021

📌 Commit 15cdb28 has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2021
@bors
Copy link
Collaborator

bors commented Jun 20, 2021

⌛ Testing commit 15cdb28 with merge 192920c...

@bors
Copy link
Collaborator

bors commented Jun 20, 2021

☀️ Test successful - checks-actions
Approved by: m-ou-se
Pushing 192920c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 20, 2021
@bors bors merged commit 192920c into rust-lang:master Jun 20, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jun 20, 2021
@fee1-dead fee1-dead deleted the fixed-encode_wide branch July 19, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@m-ou-se m-ou-se

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.

EncodeWide::size_hint doesn't account for self.extra
5 participants
@fee1-dead @rust-highfive @m-ou-se @bors @rustbot