Skip to content

Update browser-ui-test version #86468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

GuillaumeGomez
Copy link
Member

It greatly improves the test readability (thanks to @jsha for the suggestions!).

r? @jsha

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 19, 2021
@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez GuillaumeGomez force-pushed the update-browser-ui-test-version branch from 75988c8 to 1e222ba Compare June 19, 2021 12:19
@jsha
Copy link
Contributor

jsha commented Jun 20, 2021

Awesome improvement! Much clearer.

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 20, 2021

📌 Commit 1e222ba has been approved by jsha

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2021
@bors
Copy link
Collaborator

bors commented Jun 20, 2021

⌛ Testing commit 1e222ba with merge 9543636...

@bors
Copy link
Collaborator

bors commented Jun 20, 2021

☀️ Test successful - checks-actions
Approved by: jsha
Pushing 9543636 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 20, 2021
@bors bors merged commit 9543636 into rust-lang:master Jun 20, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jun 20, 2021
@GuillaumeGomez GuillaumeGomez deleted the update-browser-ui-test-version branch June 20, 2021 09:13
@jyn514 jyn514 added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants